Fix/6064 default if empty and related fixes #6070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument BREAKING CHANGE: `defaultIfEmpty` requires a value be passed. Will no longer convert `undefined` to `null` for no good reason. Resolves ReactiveX#6064
benlesh
commented
Mar 1, 2021
backbone87
reviewed
Mar 1, 2021
kolodny
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(defaultIfEmpty): Allow
undefinedas an argument, require an argumentBREAKING CHANGE:
defaultIfEmptyrequires a value be passed. Will no longer convertundefinedtonullfor no good reason.Resolves the
defaultIfEmptyoperator has erroneous & inconvenient typing #6064fix(last): Allow
defaultValueofundefined.fix(first): Allow
defaultValueofundefined.fix(elementAt): Allow
defaultValueofundefined.